Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python 3.8 on Travis. #38

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Conversation

mauritsvanrees
Copy link
Member

  • Trivial change, so no changelog entry.
  • No code change, so no Jenkins jobs needed.

@mister-roboto
Copy link

@mauritsvanrees thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

icemac
icemac previously requested changes Apr 6, 2020
Copy link

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But testing 3.8 is also missing in tox.ini.

@mauritsvanrees
Copy link
Member Author

This PR already adds 3.8 in tox.ini. : -) It just is not in the title of the PR.

@mauritsvanrees mauritsvanrees merged commit 5dcfcf7 into master Apr 16, 2020
@mauritsvanrees mauritsvanrees deleted the maurits/check-python-versions branch April 16, 2020 22:19
@icemac
Copy link

icemac commented Apr 17, 2020

This PR already adds 3.8 in tox.ini. : -) It just is not in the title of the PR.

Sorry for the noise, I overlooked it in the diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants